Delete publishing_api_finder_publisher.rb#3605
Merged
Conversation
hannako
reviewed
Apr 28, 2026
Contributor
hannako
left a comment
hannako
left a comment
There was a problem hiding this comment.
Excellent detective work!
For posterity, could you add some additional information to the PR description.
#1967 to give context to the commit I think would be helpful.
And then could you link to https://github.com/alphagov/search-api/blob/main/lib/tasks/publishing_api.rake#L10 which eventually calls https://github.com/alphagov/search-api/blob/main/lib/content_item_publisher/finder_presenter.rb#L2 as the route to publish finders from this application.
hannako
approved these changes
Apr 28, 2026
Classes in this file are no longer referenced in search-api and can be removed. They used to be used in a rake task that published the "advanced search finder" until this was updated to be published in the same way as other finders [1][2]. The deprecated rake task used a class called PublishingApiFinderPublisher that was removed [3] but the other classes in this file that PublishingApiFinderPublisher referenced were not deleted at that time. This is overdue clean up. [1] #1492 [2] https://github.com/alphagov/search-api/blob/main/lib/tasks/publishing_api.rake#L10 [3] #1967
emmalowe
force-pushed
the
remove-publishing-api-finder-publisher
branch
from
26e9fef to
54a1ca8
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes in this file are no longer referenced in search-api and can be removed. They used to be used in a rake task that published the "advanced search finder" until this was updated to be published in the same way as other finders [1][2].
The deprecated rake task used a class called
PublishingApiFinderPublisher that was removed [3] but the other classes in this file that PublishingApiFinderPublisher referenced were not deleted at that time. This is overdue clean up.
[1] #1492
[2] https://github.com/alphagov/search-api/blob/main/lib/tasks/publishing_api.rake#L10
[3] #1967